-
-
Notifications
You must be signed in to change notification settings - Fork 571
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add dynamic column width support #867
base: main
Are you sure you want to change the base?
Conversation
694e03f
to
f84be4d
Compare
I have made here a repository which generates random user data and creates a pdf with the data. |
I have noticed that the width of the columns differs on the different sheets. This is due to the "ShowOnce" element. On page 2, the sizes of the cells from page 1 are not calculated because they are already rendered. |
It is expected that elements may have different sizes across pages. ShowOnce is only one potential root cause. I understand the desired behavior is that shrank/grown columns should have identical widths across all pages. In such a case, determining all widths will be genuinely challenging, as changing width also potentially changes displayed content, creating a feedback loop. |
Personally, I don't care if the columns are the same width on each sheet. For me it fits as it is after the PR. |
I have updated the pr to fix the different columns width per page. |
Hi @MarcinZiabek, I hope you're doing well. I wanted to kindly remind you about the pull request. I have made some adjustments and have been waiting for your feedback. If you could find some time to review the changes, I would greatly appreciate it. Thank you very much for your help and time. Best regards |
@Hummel37 Let me thank you once again for exploring this feature and submitting a pull request. I apologize for the delayed response and action. Ensuring the quality of the 2024.3.X release has been my top priority recently. Although things are slowly stabilizing, it still demands a surprising amount of time. At this moment, I plan to release the final 2024.3.X version soon, and then focus on the upcoming major release. Considering that the Table element is one of the most commonly used components, I need to be very careful when introducing changes:
That being said, I am committed to revisiting every open pull request and doing my best to implement them. |
I am currently preparing a roadmap for the upcoming months. I am excited to include this enhancement, likely for the August release. I will share more details next week. Thank you for your feedback, support and patience 😄 |
Add support for dynamic column width. #517
This currently only works for cells that don't use row or column spans.